DO NOT MERGE Changed the workflow to be able to support installation of older versions of clang#174
Open
DO NOT MERGE Changed the workflow to be able to support installation of older versions of clang#174
Conversation
Member
|
I think a different approach is needed here. It will be hard to install all these old clang versions, but they are very old. After all, we are at clang-21 now. So we should change the versions of clang for which we test. For 3.12, we compile with clang-19, so this should be in the mix. Maybe we stick to the versions of clang which are in popular Ubuntu releases? It seems that Ubuntu 24.04 LTS has clang versions 14 to 20 and the default is 18. And it has gcc-9 to gcc-14 with 13 being the default. Let's try to use only that Ubuntu and then as many compilers as work reasonably from this list. |
cpjulia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: for now, we will wait for an approach, probably to dismiss the tests with older clangs, so this PR remains open as a placeholder as it might be used to apply this approach
This PR changes the CI workflow for correcting the error that occurs when tests begin (shown in the screenshot below).
GitHub's ubuntu-latest runner switched to a later Ubuntu version that doesn't support clang 11 and 12 in its default repositories, and these versions are included in our matrix. As can be seen in the screenshot, the package list shows entries the prefix noble which is for Ubuntu 24.04, not jammy jellyfish anymore as in 22.04.
So we have to go to llvm-toolchain repository for the correct Ubuntu version codename to allow apt to install the versions needed. It's ends up being a mix of both distributions, but so far the only solution found.
EDIT: trying now with focal fossa because there's no repository for clang-12 in jammy either